<html>
<head><meta charset="utf-8"><title>1.53 release · t-release · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/index.html">t-release</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html">1.53 release</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="238182318"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/238182318" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#238182318">(May 10 2021 at 17:40)</a>:</h4>
<p>Would someone be up for kicking off crater? Should be mostly a matter of looking at the 1.52 issue (which can be closed now) and rerunning the commands with bumped versions</p>



<a name="238471739"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/238471739" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#238471739">(May 12 2021 at 13:19)</a>:</h4>
<p>alright going to go ahead and do this</p>



<a name="239606083"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/239606083" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#239606083">(May 20 2021 at 14:58)</a>:</h4>
<p>fyi, crater is semi-broken due to a large amount of cargo-lockfile updates being required, see some discussion in <a class="stream-topic" data-stream-id="246057" href="/#narrow/stream/246057-t-cargo/topic/git.20dep.20getting.20updated.20in.20crater.20on.201.2E53.20beta">#t-cargo &gt; git dep getting updated in crater on 1.53 beta</a> . I expect we'll just document this as known compat note, but in the meantime I expect to submit a PR against Crater so we can avoid digging through 1,500 regressions (mostly github repositories)</p>



<a name="239606214"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/239606214" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#239606214">(May 20 2021 at 14:59)</a>:</h4>
<p>it's... unfortunate that bumping the version changes the lockfile</p>



<a name="239606288"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/239606288" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#239606288">(May 20 2021 at 14:59)</a>:</h4>
<p>is the new lockfile only supported on 1.53? or is it supported on older versions too?</p>



<a name="239606307"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/239606307" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#239606307">(May 20 2021 at 14:59)</a>:</h4>
<p>actually, let me write it on <a class="stream" data-stream-id="246057" href="/#narrow/stream/246057-t-cargo">#t-cargo</a></p>



<a name="239606311"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/239606311" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#239606311">(May 20 2021 at 14:59)</a>:</h4>
<p>I'm not sure, but I suspect only 1.53+</p>



<a name="239606343"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/239606343" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#239606343">(May 20 2021 at 14:59)</a>:</h4>
<p>this isn't the first time though and won't be the last</p>



<a name="239606418"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/239606418" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#239606418">(May 20 2021 at 15:00)</a>:</h4>
<p>Ultimately MSRV is not something we usually care much about</p>



<a name="242582319"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242582319" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242582319">(Jun 14 2021 at 11:19)</a>:</h4>
<p><span class="user-mention" data-user-id="116122">@simulacrum</span> did you have the time to go through all the regressions this weekend?</p>



<a name="242582379"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242582379" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242582379">(Jun 14 2021 at 11:20)</a>:</h4>
<p>for reasons I can't really do much technical work today, so I can spend some time going through issues if you didn't get a chance</p>



<a name="242582417"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242582417" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242582417">(Jun 14 2021 at 11:20)</a>:</h4>
<p>I unfortunately didn't and am likely to be short on time today - I did a cursory glance and nothing looked horrible but it wasn't even clicking into individual issues</p>



<a name="242582443"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242582443" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242582443">(Jun 14 2021 at 11:20)</a>:</h4>
<p>ok I'll go through them to fill my day</p>



<a name="242582484"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242582484" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242582484">(Jun 14 2021 at 11:21)</a>:</h4>
<p>Sounds good. I should be good for the actual release steps but this week is going to be busy for me fyi</p>



<a name="242602489"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242602489" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242602489">(Jun 14 2021 at 14:11)</a>:</h4>
<p>opened <a href="https://hackmd.io/W6nE6oY_SHWDtnrODVZGOw?both">https://hackmd.io/W6nE6oY_SHWDtnrODVZGOw?both</a> with my in-progress triage</p>



<a name="242606151"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242606151" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242606151">(Jun 14 2021 at 14:35)</a>:</h4>
<p><span class="user-mention" data-user-id="116083">@pnkfelix</span> you beat me to closing <a href="https://github.com/rust-lang/rust/issues/84297">https://github.com/rust-lang/rust/issues/84297</a> by a couple seconds <span aria-label="laughing" class="emoji emoji-1f606" role="img" title="laughing">:laughing:</span></p>



<a name="242606240"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242606240" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242606240">(Jun 14 2021 at 14:35)</a>:</h4>
<p><span class="user-mention" data-user-id="116122">@simulacrum</span> <span class="user-mention" data-user-id="116083">@pnkfelix</span> ok here is a summary of all the beta regressions <a href="https://hackmd.io/W6nE6oY_SHWDtnrODVZGOw">https://hackmd.io/W6nE6oY_SHWDtnrODVZGOw</a></p>



<a name="242606557"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242606557" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242606557">(Jun 14 2021 at 14:37)</a>:</h4>
<p>will now triage nightly regressions to make sure nothing was misclassified</p>



<a name="242607471"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242607471" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242607471">(Jun 14 2021 at 14:43)</a>:</h4>
<p>nothing that seems to be tracked for the release for the regressions, I think, though definitely a few annoying at least issues to still have open</p>



<a name="242607478"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242607478" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242607478">(Jun 14 2021 at 14:43)</a>:</h4>
<p>ok there were no misclassified nightly regressions</p>



<a name="242610576"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242610576" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242610576">(Jun 14 2021 at 15:02)</a>:</h4>
<p>oh, there is also <a href="https://github.com/rust-lang/rust/issues/86286">https://github.com/rust-lang/rust/issues/86286</a></p>



<a name="242611674"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242611674" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242611674">(Jun 14 2021 at 15:08)</a>:</h4>
<p>not a regression</p>



<a name="242611698"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242611698" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242611698">(Jun 14 2021 at 15:09)</a>:</h4>
<p>so we're not likely to backport or anything like that there</p>



<a name="242611745"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242611745" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242611745">(Jun 14 2021 at 15:09)</a>:</h4>
<p>also shouldn't affect rustup which is the primary thing we care about imo</p>



<a name="242617764"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242617764" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242617764">(Jun 14 2021 at 15:46)</a>:</h4>
<p><span class="user-mention silent" data-user-id="121055">Pietro Albini</span> <a href="#narrow/stream/241545-t-release/topic/1.2E53.20release/near/242602489">said</a>:</p>
<blockquote>
<p>opened <a href="https://hackmd.io/W6nE6oY_SHWDtnrODVZGOw?both">https://hackmd.io/W6nE6oY_SHWDtnrODVZGOw?both</a> with my in-progress triage</p>
</blockquote>
<p>Thanks for putting this together</p>



<a name="242617803"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242617803" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242617803">(Jun 14 2021 at 15:47)</a>:</h4>
<p>I am surprised we haven’t just reverted the injecting PR to resolve issue <a href="https://github.com/rust-lang/rust/issues/85713">#85713</a></p>



<a name="242617888"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242617888" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242617888">(Jun 14 2021 at 15:47)</a>:</h4>
<p>Let me look into that</p>



<a name="242626653"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242626653" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242626653">(Jun 14 2021 at 16:47)</a>:</h4>
<p>Put up PR <a href="https://github.com/rust-lang/rust/issues/86300">#86300</a> for that.</p>



<a name="242628260"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242628260" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> cuviper <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242628260">(Jun 14 2021 at 16:59)</a>:</h4>
<p><span class="user-mention" data-user-id="116083">@pnkfelix</span> we still need <code>RUSTC_FORCE_INCREMENTAL</code> for 1.53, right?</p>



<a name="242628289"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242628289" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> cuviper <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242628289">(Jun 14 2021 at 16:59)</a>:</h4>
<p>i.e. <a href="https://github.com/rust-lang/rust/issues/86004">#86004</a></p>



<a name="242628316"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242628316" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242628316">(Jun 14 2021 at 16:59)</a>:</h4>
<p>Yep’ll we’ll need that on the 1.53 stable</p>



<a name="242628428"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242628428" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242628428">(Jun 14 2021 at 17:00)</a>:</h4>
<p>I admit I’m somewhat regretting my prior stance on not putting RUSTC_FORCE_INCREMENTAL onto 1.53-beta</p>



<a name="242628460"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242628460" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242628460">(Jun 14 2021 at 17:00)</a>:</h4>
<p>(i.e.. I suspect that stance didn’t buy us much, and just made for headaches now)</p>



<a name="242628796"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242628796" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> cuviper <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242628796">(Jun 14 2021 at 17:02)</a>:</h4>
<p>ok, are you still planning to commit this yourself? need help?</p>



<a name="242628873"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242628873" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242628873">(Jun 14 2021 at 17:03)</a>:</h4>
<p>i probably need help just knowing <em>when</em> and <em>where</em> to land it</p>



<a name="242628955"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242628955" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242628955">(Jun 14 2021 at 17:04)</a>:</h4>
<p>i.e. is now the time?</p>



<a name="242629022"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242629022" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242629022">(Jun 14 2021 at 17:04)</a>:</h4>
<p>and should it just be put up as a PR against the beta branch today?</p>



<a name="242629027"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242629027" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> cuviper <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242629027">(Jun 14 2021 at 17:04)</a>:</h4>
<p>I'd say ASAP, yes, on <code>beta</code></p>



<a name="242629046"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242629046" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242629046">(Jun 14 2021 at 17:04)</a>:</h4>
<p>okay. I can do that.</p>



<a name="242629159"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242629159" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242629159">(Jun 14 2021 at 17:05)</a>:</h4>
<p><span class="user-mention" data-user-id="116083">@pnkfelix</span> I was expecting to include it in the beta to stable PR, alongside any other last minute backports</p>



<a name="242629169"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242629169" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> cuviper <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242629169">(Jun 14 2021 at 17:05)</a>:</h4>
<p>ah</p>



<a name="242629190"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242629190" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242629190">(Jun 14 2021 at 17:05)</a>:</h4>
<p>Mostly to avoid wasting a cycle of bors</p>



<a name="242629195"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242629195" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242629195">(Jun 14 2021 at 17:05)</a>:</h4>
<p><span class="user-mention" data-user-id="116122">@simulacrum</span> okay that works too</p>



<a name="242629277"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242629277" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242629277">(Jun 14 2021 at 17:06)</a>:</h4>
<p>But if you want to get a commit or patch or whatever that's guaranteed to cherry pick cleanly that's good prep work</p>



<a name="242629290"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242629290" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242629290">(Jun 14 2021 at 17:06)</a>:</h4>
<p>It should be a simple patch iirc so I don't expect problems</p>



<a name="242629324"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242629324" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> cuviper <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242629324">(Jun 14 2021 at 17:06)</a>:</h4>
<p>in general, I'd rather we avoid such last minute additions</p>



<a name="242629335"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242629335" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242629335">(Jun 14 2021 at 17:06)</a>:</h4>
<p><span class="user-mention" data-user-id="116122">@simulacrum</span> okay, maybe I’ll put up a PR against <code>beta</code> marked as “DRAFT” and then point you at it?</p>



<a name="242629337"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242629337" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> cuviper <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242629337">(Jun 14 2021 at 17:06)</a>:</h4>
<p>e.g. I don't see why this patch was waiting</p>



<a name="242629348"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242629348" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242629348">(Jun 14 2021 at 17:06)</a>:</h4>
<p>Sure that works</p>



<a name="242629375"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242629375" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242629375">(Jun 14 2021 at 17:07)</a>:</h4>
<p><span class="user-mention" data-user-id="138448">@cuviper</span> as in, why didn’t we land it on <code>beta</code> earlier?</p>



<a name="242629378"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242629378" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242629378">(Jun 14 2021 at 17:07)</a>:</h4>
<p>It was waiting because we didn't want people to avoid beta because of thisd</p>



<a name="242629385"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242629385" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242629385">(Jun 14 2021 at 17:07)</a>:</h4>
<p>Yes, that</p>



<a name="242629420"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242629420" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242629420">(Jun 14 2021 at 17:07)</a>:</h4>
<p>namely at least one developer (Carol) was using beta because it fixed incr-comp for her</p>



<a name="242629517"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242629517" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> cuviper <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242629517">(Jun 14 2021 at 17:08)</a>:</h4>
<p>hmm, well that sets a weird expectation IMO, if those same people are hoping the beta behavior will continue in stable</p>



<a name="242629534"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242629534" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242629534">(Jun 14 2021 at 17:08)</a>:</h4>
<p>yes, that is one reason why I’m regretting my prior stance</p>



<a name="242629559"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242629559" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242629559">(Jun 14 2021 at 17:08)</a>:</h4>
<p>I think everyone understood it wouldn't personally and I think it was the right choice</p>



<a name="242629619"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242629619" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> cuviper <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242629619">(Jun 14 2021 at 17:08)</a>:</h4>
<p>well it's almost done now, but let's please not make a habit of that</p>



<a name="242629633"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242629633" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242629633">(Jun 14 2021 at 17:08)</a>:</h4>
<p>I don't generally like playing with channels but I don't think it was wrong to do so in this case</p>



<a name="242629691"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242629691" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242629691">(Jun 14 2021 at 17:09)</a>:</h4>
<p><span class="user-mention silent" data-user-id="138448">cuviper</span> <a href="#narrow/stream/241545-t-release/topic/1.2E53.20release/near/242629619">said</a>:</p>
<blockquote>
<p>well it's almost done now, but let's please not make a habit of that</p>
</blockquote>
<p>right, I’m personally planning to make a point of saying that this should <em>not</em> be used as precedent in future decisions</p>



<a name="242633166"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242633166" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242633166">(Jun 14 2021 at 17:33)</a>:</h4>
<p><span class="user-mention silent" data-user-id="116083">pnkfelix</span> <a href="#narrow/stream/241545-t-release/topic/1.2E53.20release/near/242629335">said</a>:</p>
<blockquote>
<p><span class="user-mention silent" data-user-id="116122">simulacrum</span> okay, maybe I’ll put up a PR against <code>beta</code> marked as “DRAFT” and then point you at it?</p>
</blockquote>
<p>See PR <a href="https://github.com/rust-lang/rust/issues/86301">#86301</a></p>



<a name="242664164"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242664164" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242664164">(Jun 14 2021 at 21:56)</a>:</h4>
<p>okay, going to proceed here with 1.53 beta-&gt;stable promotion shortly</p>



<a name="242664244"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242664244" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242664244">(Jun 14 2021 at 21:58)</a>:</h4>
<p>force pushed</p>



<a name="242666153"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242666153" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242666153">(Jun 14 2021 at 22:20)</a>:</h4>
<p><span class="user-mention" data-user-id="116083">@pnkfelix</span> will you have time today to finish <a href="https://github.com/rust-lang/rust/pull/86301">https://github.com/rust-lang/rust/pull/86301</a> or should I put that on my agenda before finalizing the promotion? I should have time, but of course would prefer to not spend it on this :)</p>



<a name="242671539"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242671539" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242671539">(Jun 14 2021 at 23:28)</a>:</h4>
<p>ok, taking over here</p>



<a name="242671830"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242671830" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242671830">(Jun 14 2021 at 23:32)</a>:</h4>
<p>Oh I didn’t realize the error messaging changes were never put into beta</p>



<a name="242671851"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242671851" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242671851">(Jun 14 2021 at 23:33)</a>:</h4>
<p>Sorry about that.</p>



<a name="242672311"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242672311" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242672311">(Jun 14 2021 at 23:40)</a>:</h4>
<p>ok, <a href="https://github.com/rust-lang/rust/pull/86317">https://github.com/rust-lang/rust/pull/86317</a> is now open</p>



<a name="242672340"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242672340" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242672340">(Jun 14 2021 at 23:41)</a>:</h4>
<p>Hopefully that passes CI, I'm not sure if my patch for the incremental test failures seen on the PR Felix opened will be sufficient</p>



<a name="242714703"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242714703" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242714703">(Jun 15 2021 at 10:33)</a>:</h4>
<p><span class="user-mention" data-user-id="116122">@simulacrum</span> wait, are we keeping <a href="https://github.com/rust-lang/rust/issues/85667">https://github.com/rust-lang/rust/issues/85667</a> in?</p>



<a name="242714716"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242714716" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242714716">(Jun 15 2021 at 10:33)</a>:</h4>
<p>1300 regressed crates is <em>a lot</em></p>



<a name="242720759"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242720759" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242720759">(Jun 15 2021 at 11:46)</a>:</h4>
<p>I don't know</p>



<a name="242720789"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242720789" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242720789">(Jun 15 2021 at 11:46)</a>:</h4>
<p>It's the sort of case where we really don't have a framework to make a decision imo</p>



<a name="242720998"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242720998" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242720998">(Jun 15 2021 at 11:48)</a>:</h4>
<p>It is technically allowed breakage</p>



<a name="242721641"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242721641" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242721641">(Jun 15 2021 at 11:56)</a>:</h4>
<p>I would strongly prefer to back it down until we have less regressions</p>



<a name="242722518"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242722518" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242722518">(Jun 15 2021 at 12:07)</a>:</h4>
<p>That's just not going to happen though? Like, these regressions are mostly pinned I think</p>



<a name="242722674"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242722674" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242722674">(Jun 15 2021 at 12:08)</a>:</h4>
<p>With cargo update -p lexical-core many of them will be fixed I think. Maybe we should add an option to run cargo update (but without git deps ideally) in crater...</p>



<a name="242723007"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242723007" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242723007">(Jun 15 2021 at 12:12)</a>:</h4>
<p>then I think we should consider other options rather than breaking 1.3k projects</p>



<a name="242723051"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242723051" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242723051">(Jun 15 2021 at 12:12)</a>:</h4>
<p>we shouldn't break that many crates</p>



<a name="242723113"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242723113" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242723113">(Jun 15 2021 at 12:13)</a>:</h4>
<p>also my understanding is that the libs team didn't even have a chance to discuss that due to mislabeling</p>



<a name="242728226"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242728226" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242728226">(Jun 15 2021 at 13:00)</a>:</h4>
<p>they discussed that issue</p>



<a name="242728268"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242728268" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242728268">(Jun 15 2021 at 13:01)</a>:</h4>
<p>or at least, <span class="user-mention" data-user-id="310399">@Mara</span> left comments</p>



<a name="242728373"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242728373" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242728373">(Jun 15 2021 at 13:01)</a>:</h4>
<p>ultimately if we want to back out BITS I'm not opposed, I just don't really know either way</p>



<a name="242728509"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242728509" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242728509">(Jun 15 2021 at 13:02)</a>:</h4>
<p><span class="user-mention" data-user-id="121055">@Pietro Albini</span> I'll hold off on dev-static'ing the stable release for now then? If we want to rebuild without BITS</p>



<a name="242729015"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242729015" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Mara <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242729015">(Jun 15 2021 at 13:06)</a>:</h4>
<p><span class="user-mention silent" data-user-id="116122">simulacrum</span> <a href="#narrow/stream/241545-t-release/topic/1.2E53.20release/near/242720789">said</a>:</p>
<blockquote>
<p>It's the sort of case where we really don't have a framework to make a decision imo</p>
</blockquote>
<p>yeah, that's the problem. i honstely don't know what to do here. and discussions in the team meeting don't come to clear conclusions either. :/</p>



<a name="242729034"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242729034" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> XAMPPRocky <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242729034">(Jun 15 2021 at 13:06)</a>:</h4>
<p>Yeah, I've been lurking, and agree with Mark that I'm not sure reverting it is productive, because it doesn't seem like much will change between releases, but I'm also not unopposed to the revert. I think the important thing is that we should some kind of path laid out for the change to land or be removed. Rather than continue to just land and revert, and hope the number goes down.</p>



<a name="242729069"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242729069" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242729069">(Jun 15 2021 at 13:07)</a>:</h4>
<p>cc <span class="user-group-mention" data-user-group-id="2907">@T-release</span></p>



<a name="242729129"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242729129" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242729129">(Jun 15 2021 at 13:07)</a>:</h4>
<p>Ultimately for me personally I'd be happy with confirmation that there are patch versions (i.e., cargo update is sufficient) for each "channel" published of the lexical-core crate</p>



<a name="242729163"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242729163" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> XAMPPRocky <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242729163">(Jun 15 2021 at 13:07)</a>:</h4>
<p>Same</p>



<a name="242729165"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242729165" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242729165">(Jun 15 2021 at 13:07)</a>:</h4>
<p>I asked yesterday but I don't think there's been a response; it's likely not too hard to figure out based on <a href="http://crates.io">crates.io</a> history</p>



<a name="242729229"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242729229" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242729229">(Jun 15 2021 at 13:08)</a>:</h4>
<p>I don't think I'll have the time to try to figure that out, though</p>



<a name="242729339"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242729339" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242729339">(Jun 15 2021 at 13:09)</a>:</h4>
<p>if we want to land this IMO we should back it out right now and do a <code>cargo update</code> crater run</p>



<a name="242729346"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242729346" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242729346">(Jun 15 2021 at 13:09)</a>:</h4>
<p>I decided I'll push up dev-static artifacts so we can get them out for testing, and then we can always rebuild them.</p>



<a name="242729397"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242729397" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242729397">(Jun 15 2021 at 13:09)</a>:</h4>
<p><span class="user-mention silent" data-user-id="121055">Pietro Albini</span> <a href="#narrow/stream/241545-t-release/topic/1.2E53.20release/near/242729339">said</a>:</p>
<blockquote>
<p>if we want to land this IMO we should back it out right now and do a <code>cargo update</code> crater run</p>
</blockquote>
<p>Is this a thing we can actually do? It'd be closer to cargo update -p lexical-core or so, I suspect; cargo update broadly will also bump git deps and we don't want that.</p>



<a name="242729457"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242729457" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242729457">(Jun 15 2021 at 13:10)</a>:</h4>
<p><span class="user-mention silent" data-user-id="116122">simulacrum</span> <a href="#narrow/stream/241545-t-release/topic/1.2E53.20release/near/242729397">said</a>:</p>
<blockquote>
<p><span class="user-mention silent" data-user-id="121055">Pietro Albini</span> <a href="#narrow/stream/241545-t-release/topic/1.2E53.20release/near/242729339">said</a>:</p>
<blockquote>
<p>if we want to land this IMO we should back it out right now and do a <code>cargo update</code> crater run</p>
</blockquote>
<p>Is this a thing we can actually do? It'd be closer to cargo update -p lexical-core or so, I suspect; cargo update broadly will also bump git deps and we don't want that.</p>
</blockquote>
<p>implementing support for that shouldn't be too hard</p>



<a name="242729485"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242729485" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> XAMPPRocky <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242729485">(Jun 15 2021 at 13:10)</a>:</h4>
<p><span class="user-mention silent" data-user-id="116122">simulacrum</span> <a href="#narrow/stream/241545-t-release/topic/1.2E53.20release/near/242729165">said</a>:</p>
<blockquote>
<p>I asked yesterday but I don't think there's been a response; it's likely not too hard to figure out based on <a href="http://crates.io">crates.io</a> history</p>
</blockquote>
<p>I checked earlier, there is patches for all of the minor versions from about 2 months ago.</p>



<a name="242729486"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242729486" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242729486">(Jun 15 2021 at 13:10)</a>:</h4>
<p>I think</p>



<a name="242729501"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242729501" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Mara <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242729501">(Jun 15 2021 at 13:10)</a>:</h4>
<p><span class="user-mention silent" data-user-id="116122">simulacrum</span> <a href="#narrow/stream/241545-t-release/topic/1.2E53.20release/near/242729165">said</a>:</p>
<blockquote>
<p>I asked yesterday but I don't think there's been a response; it's likely not too hard to figure out based on <a href="http://crates.io">crates.io</a> history</p>
</blockquote>
<p><a href="/user_uploads/4715/cUcrofBS8XOqmnG2h7yMTihK/image.png">image.png</a></p>
<div class="message_inline_image"><a href="/user_uploads/4715/cUcrofBS8XOqmnG2h7yMTihK/image.png" title="image.png"><img src="/user_uploads/4715/cUcrofBS8XOqmnG2h7yMTihK/image.png"></a></div>



<a name="242729545"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242729545" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Mara <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242729545">(Jun 15 2021 at 13:11)</a>:</h4>
<p>these were updated recently. checking now if they include the patch for BITS</p>



<a name="242729560"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242729560" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242729560">(Jun 15 2021 at 13:11)</a>:</h4>
<p>that seems odd given that the discussion with myrrlyn was only ~20 days ago</p>



<a name="242729734"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242729734" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Mara <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242729734">(Jun 15 2021 at 13:12)</a>:</h4>
<p><a href="https://github.com/Alexhuszagh/rust-lexical/pull/56">https://github.com/Alexhuszagh/rust-lexical/pull/56</a> was 13 feb</p>



<a name="242730217"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242730217" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Mara <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242730217">(Jun 15 2021 at 13:16)</a>:</h4>
<p>0.4.8, 0.5.1, 0.6.8, and 0.7.6 all include the BITS patch.</p>



<a name="242730280"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242730280" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Mara <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242730280">(Jun 15 2021 at 13:16)</a>:</h4>
<p>(checked the source on <a href="http://crates.io">crates.io</a>, not on github)</p>



<a name="242730364"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242730364" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242730364">(Jun 15 2021 at 13:17)</a>:</h4>
<p>ok, so that's all of the ones regressed on the crater run</p>



<a name="242730401"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242730401" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242730401">(Jun 15 2021 at 13:17)</a>:</h4>
<p><span class="user-mention" data-user-id="121055">@Pietro Albini</span> I am personally inclined to not bother reverting and waiting for crater to get the cargo update logic implemented and run</p>



<a name="242730468"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242730468" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242730468">(Jun 15 2021 at 13:18)</a>:</h4>
<p>hmm</p>



<a name="242730476"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242730476" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> cuviper <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242730476">(Jun 15 2021 at 13:18)</a>:</h4>
<p>How about a compatibility note?</p>



<a name="242730498"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242730498" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242730498">(Jun 15 2021 at 13:18)</a>:</h4>
<p>I guess I'm still really worried about breaking that many crates</p>



<a name="242730550"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242730550" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242730550">(Jun 15 2021 at 13:19)</a>:</h4>
<p>s/crates/projects, to be clear. in theory ~no <a href="http://crates.io">crates.io</a> crate is going to break as those don't generally pin their dep</p>



<a name="242730728"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242730728" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242730728">(Jun 15 2021 at 13:20)</a>:</h4>
<p>still, that's a lot</p>



<a name="242730796"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242730796" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Mara <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242730796">(Jun 15 2021 at 13:20)</a>:</h4>
<p>so reverting it would postpone the problem six weeks. is that just to give crates more time to upgrade their deps, or would we work on some workaround (compiler ignoring the constant in some cases, or renaming it, or..)?</p>



<a name="242730845"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242730845" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242730845">(Jun 15 2021 at 13:21)</a>:</h4>
<p>if we can find a workaround that'd be great</p>



<a name="242730851"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242730851" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242730851">(Jun 15 2021 at 13:21)</a>:</h4>
<p>Basically I don't think reverting makes sense if we're going to end up landing it as-is, more time in the 'few cycles' range won't change anything</p>



<a name="242730871"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242730871" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Mara <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242730871">(Jun 15 2021 at 13:21)</a>:</h4>
<p><a href="/user_uploads/4715/uusvwS72Lnf_k1fppeL93Y8R/image.png">image.png</a></p>
<div class="message_inline_image"><a href="/user_uploads/4715/uusvwS72Lnf_k1fppeL93Y8R/image.png" title="image.png"><img src="/user_uploads/4715/uusvwS72Lnf_k1fppeL93Y8R/image.png"></a></div>



<a name="242730963"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242730963" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Mara <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242730963">(Jun 15 2021 at 13:22)</a>:</h4>
<p>looks like by downloads (so, 'active' crates), most have updated already</p>



<a name="242731006"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242731006" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242731006">(Jun 15 2021 at 13:22)</a>:</h4>
<p>Is that a stack graph? Or is that just new downloads?</p>



<a name="242731081"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242731081" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242731081">(Jun 15 2021 at 13:22)</a>:</h4>
<p>iirc it's stacked</p>



<a name="242731103"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242731103" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242731103">(Jun 15 2021 at 13:22)</a>:</h4>
<p>yeah, stacked</p>



<a name="242731104"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242731104" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Mara <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242731104">(Jun 15 2021 at 13:22)</a>:</h4>
<p><a href="/user_uploads/4715/ytxMcgXpvVgUB5XoK3HP2uaZ/image.png">image.png</a> numbers</p>
<div class="message_inline_image"><a href="/user_uploads/4715/ytxMcgXpvVgUB5XoK3HP2uaZ/image.png" title="image.png"><img src="/user_uploads/4715/ytxMcgXpvVgUB5XoK3HP2uaZ/image.png"></a></div>



<a name="242731133"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242731133" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242731133">(Jun 15 2021 at 13:23)</a>:</h4>
<p>this just seems to lend more credence to the idea that there's not much point in waiting another cycle</p>



<a name="242731361"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242731361" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Mara <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242731361">(Jun 15 2021 at 13:24)</a>:</h4>
<p>this problem keeps popping up while extending the standard library though. varies a lot what the impact is, but we keep having to make this decision, which is too often driven by 'oh, out of time' :(   maybe we should set a meeting or something to talk about some kind of policy. or some more general mechanism to avoid breakage in the compiler.. idk</p>



<a name="242731429"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242731429" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242731429">(Jun 15 2021 at 13:25)</a>:</h4>
<p>well, that's still a bit less than 1/3rd of the downloads that are still on the old versions</p>



<a name="242731459"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242731459" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242731459">(Jun 15 2021 at 13:25)</a>:</h4>
<p>if we had it (e.g., the std-version or whatever you suggested), I absolutely think we should/would use it.</p>



<a name="242731498"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242731498" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242731498">(Jun 15 2021 at 13:25)</a>:</h4>
<p>to some extent it's not yet clear that this is a problem we must tackle <em>now</em>, though, and the design space is complex.</p>



<a name="242731607"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242731607" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242731607">(Jun 15 2021 at 13:26)</a>:</h4>
<p>with this breakage if we intend add a mechanism like that I'd delay the stabilization until it's ready</p>



<a name="242731636"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242731636" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242731636">(Jun 15 2021 at 13:26)</a>:</h4>
<p>I really don't think that's a reasonable position</p>



<a name="242731647"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242731647" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Mara <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242731647">(Jun 15 2021 at 13:26)</a>:</h4>
<p>we already track the stabilization version in the #[stable] attributes, so half of it is already done. the other half will take a lot of discussion though</p>



<a name="242731651"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242731651" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242731651">(Jun 15 2021 at 13:26)</a>:</h4>
<p>like, that mechanism is so far off</p>



<a name="242731666"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242731666" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242731666">(Jun 15 2021 at 13:27)</a>:</h4>
<p>at least multiple cycles</p>



<a name="242731688"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242731688" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242731688">(Jun 15 2021 at 13:27)</a>:</h4>
<p>likely 6-12 months, IMO</p>



<a name="242731710"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242731710" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242731710">(Jun 15 2021 at 13:27)</a>:</h4>
<p>this doesn't seem to be a feature that has to land ASAP tho</p>



<a name="242731732"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242731732" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Mara <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242731732">(Jun 15 2021 at 13:27)</a>:</h4>
<p>that's also true</p>



<a name="242731737"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242731737" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> XAMPPRocky <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242731737">(Jun 15 2021 at 13:27)</a>:</h4>
<p><span class="user-mention silent" data-user-id="121055">Pietro Albini</span> <a href="#narrow/stream/241545-t-release/topic/1.2E53.20release/near/242731429">said</a>:</p>
<blockquote>
<p>well, that's still a bit less than 1/3rd of the downloads that are still on the old versions</p>
</blockquote>
<p>Right, but we don't know which of those are also on the latest minor and which are older unpatched releases. So it's likely less than 1/3.</p>



<a name="242731761"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242731761" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242731761">(Jun 15 2021 at 13:27)</a>:</h4>
<p>no, but there's usually 100-200 projects we break per cycle in this fashion</p>



<a name="242731877"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242731877" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242731877">(Jun 15 2021 at 13:28)</a>:</h4>
<p>if we want to take a strict policy, then we basically need to stop adding new things to std</p>



<a name="242731892"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242731892" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242731892">(Jun 15 2021 at 13:28)</a>:</h4>
<p>I am not convinced that's warranted</p>



<a name="242731969"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242731969" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242731969">(Jun 15 2021 at 13:29)</a>:</h4>
<p>I don't think being super strict is necessary, but like, here we're breaking 10x the amount you mentioned</p>



<a name="242732049"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242732049" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Mara <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242732049">(Jun 15 2021 at 13:29)</a>:</h4>
<p>but it's also 10x easier to fix the breakage this time, i suppose. since all the old versions of lexical-core have a patch available.</p>



<a name="242732136"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242732136" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242732136">(Jun 15 2021 at 13:30)</a>:</h4>
<p>Yeah, the fix for most people is going to be quite easy.</p>



<a name="242732175"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242732175" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Mara <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242732175">(Jun 15 2021 at 13:30)</a>:</h4>
<p>(but without a policy or something, i don't know if that makes it more okay to break things.)</p>



<a name="242732192"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242732192" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242732192">(Jun 15 2021 at 13:30)</a>:</h4>
<p>We <em>do</em> have a policy that says this is explicitly allowed</p>



<a name="242732202"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242732202" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242732202">(Jun 15 2021 at 13:30)</a>:</h4>
<p>We have no policy saying otherwise</p>



<a name="242732210"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242732210" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Mara <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242732210">(Jun 15 2021 at 13:30)</a>:</h4>
<p>right</p>



<a name="242732213"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242732213" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242732213">(Jun 15 2021 at 13:31)</a>:</h4>
<p>That's part of my point</p>



<a name="242732239"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242732239" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242732239">(Jun 15 2021 at 13:31)</a>:</h4>
<p>Like, I am happy to discuss and we can try to set a different bar for breakage</p>



<a name="242732264"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242732264" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> XAMPPRocky <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242732264">(Jun 15 2021 at 13:31)</a>:</h4>
<p>While I agree that the theoretical breakage of 1,300 would be bad, I'm not sure that the material breakage will be close to that. We have to account for the passage of time that's already happened and these patches being out for a release cycle before we can hold ourselves to that number.</p>



<a name="242732266"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242732266" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242732266">(Jun 15 2021 at 13:31)</a>:</h4>
<p>And I'm happy to drop BITS from this release</p>



<a name="242732422"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242732422" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242732422">(Jun 15 2021 at 13:32)</a>:</h4>
<p>but realistically it seems like we have this "fight" each release, on different scales. I think that definitely points to needing a policy discussion, but until it happens, I'd rather not stranglehold ourselves to some arbitrary-ish standard</p>



<a name="242732434"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242732434" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Mara <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242732434">(Jun 15 2021 at 13:32)</a>:</h4>
<p>say we don't revert, and release it with this breakage. if it turns out to have too much negative impact, then we have a clear signal the policy should be changed.</p>



<a name="242732568"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242732568" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242732568">(Jun 15 2021 at 13:33)</a>:</h4>
<p>we have no good way of determining that negative impact IMO</p>



<a name="242732573"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242732573" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242732573">(Jun 15 2021 at 13:33)</a>:</h4>
<p>that's part of the problem</p>



<a name="242732575"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242732575" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Mara <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242732575">(Jun 15 2021 at 13:33)</a>:</h4>
<p>but it seems there is already some vague consensus that the current policy sets the bar too low</p>



<a name="242732683"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242732683" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Mara <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242732683">(Jun 15 2021 at 13:34)</a>:</h4>
<p><span class="user-mention silent" data-user-id="116122">simulacrum</span> <a href="#narrow/stream/241545-t-release/topic/1.2E53.20release/near/242732568">said</a>:</p>
<blockquote>
<p>we have no good way of determining that negative impact IMO</p>
</blockquote>
<p>number of issues opened? disappointed tweets? yeah, it's tricky.</p>



<a name="242732703"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242732703" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> XAMPPRocky <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242732703">(Jun 15 2021 at 13:34)</a>:</h4>
<p><span class="user-mention silent" data-user-id="310399">Mara</span> <a href="#narrow/stream/241545-t-release/topic/1.2E53.20release/near/242732575">said</a>:</p>
<blockquote>
<p>but it seems there is already some vague consensus that the current policy sets the bar too low</p>
</blockquote>
<p>I don't know if the bar is too low, I think the issue is that people have different heights of where the bar should be.</p>



<a name="242732787"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242732787" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242732787">(Jun 15 2021 at 13:34)</a>:</h4>
<p>Implementing mitigation strategies like the std-version feature mentioned (not just on this issue, multiple times over the past several years at least), makes sense to me. But I don't think it would change where the bar is for me personally</p>



<a name="242732912"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242732912" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> XAMPPRocky <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242732912">(Jun 15 2021 at 13:35)</a>:</h4>
<p><span class="user-mention silent" data-user-id="310399">Mara</span> <a href="#narrow/stream/241545-t-release/topic/1.2E53.20release/near/242732434">said</a>:</p>
<blockquote>
<p>say we don't revert, and release it with this breakage. if it turns out to have too much negative impact, then we have a clear signal the policy should be changed.</p>
</blockquote>
<p>Would the onus be on us to have a patch release then if it did go negatively? If it did go negative, I would want to course correct quickly.</p>



<a name="242733052"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242733052" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242733052">(Jun 15 2021 at 13:36)</a>:</h4>
<p>But I'd tell people to do cargo update -p lexical-core, that's almost guaranteed to solve their problem</p>



<a name="242733066"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242733066" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242733066">(Jun 15 2021 at 13:36)</a>:</h4>
<p>A patch release seems really excessive</p>



<a name="242733124"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242733124" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> cuviper <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242733124">(Jun 15 2021 at 13:37)</a>:</h4>
<p>Reverting in a patch release would break anyone that started using it. I'd only do that for a soundness issue.</p>



<a name="242733130"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242733130" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> XAMPPRocky <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242733130">(Jun 15 2021 at 13:37)</a>:</h4>
<p><span class="user-mention silent" data-user-id="116122">simulacrum</span> <a href="#narrow/stream/241545-t-release/topic/1.2E53.20release/near/242732787">said</a>:</p>
<blockquote>
<p>Implementing mitigation strategies like the std-version feature mentioned (not just on this issue, multiple times over the past several years at least), makes sense to me. But I don't think it would change where the bar is for me personally</p>
</blockquote>
<p>Sure, I think those are two separate things. One being "What's an acceptable level of breakage in std?", and the other being "What lever can we pull when we want to make a change that exceeds that acceptable level?".</p>



<a name="242733326"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242733326" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242733326">(Jun 15 2021 at 13:38)</a>:</h4>
<p>Hm, well, I mean they definitely influence one another, I think</p>



<a name="242733371"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242733371" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242733371">(Jun 15 2021 at 13:39)</a>:</h4>
<p>the 'easy' option is obviously to do nothing</p>



<a name="242733762"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242733762" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> XAMPPRocky <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242733762">(Jun 15 2021 at 13:41)</a>:</h4>
<p>Yeah, but just so we're clear on the current topic of <code>::BITS</code> before we get distracted, I'm weakly in favor of doing nothing. If more people show up and feel like we should revert I have no problem with that.</p>



<a name="242734697"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242734697" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> cuviper <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242734697">(Jun 15 2021 at 13:47)</a>:</h4>
<p>I want to echo <a href="https://github.com/rust-lang/rust/issues/84133#issuecomment-819027170">this comment</a> on the array-iter hack:</p>
<blockquote>
<p>but I am worried that we're using our power as language maintainers to sidestep an issue that regularly affects end-users of the language.</p>
</blockquote>



<a name="242734882"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242734882" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Mara <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242734882">(Jun 15 2021 at 13:48)</a>:</h4>
<p>on the other hand, end-users get to use semver. release breaking changes in a new major release. we don't have that option.</p>



<a name="242734910"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242734910" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> cuviper <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242734910">(Jun 15 2021 at 13:49)</a>:</h4>
<p>Yeah</p>



<a name="242735084"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242735084" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> cuviper <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242735084">(Jun 15 2021 at 13:50)</a>:</h4>
<p>That's a big hammer though for changes that should otherwise be small</p>



<a name="242735485"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242735485" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> cuviper <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242735485">(Jun 15 2021 at 13:52)</a>:</h4>
<p>Anyway, I do think we should go ahead and ship <code>BITS</code>, with a compat note</p>



<a name="242735597"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242735597" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> cuviper <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242735597">(Jun 15 2021 at 13:53)</a>:</h4>
<p>And I think a patch-release revert should only be a severe option</p>



<a name="242762375"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242762375" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> tmandry <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242762375">(Jun 15 2021 at 16:40)</a>:</h4>
<p>My only concern is that the fix is easy to find</p>



<a name="242763103"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242763103" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> tmandry <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242763103">(Jun 15 2021 at 16:44)</a>:</h4>
<p>a compat note probably satisfies that, if it has enough of the keywords a user would search for after hitting this</p>



<a name="242779123"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242779123" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242779123">(Jun 15 2021 at 18:37)</a>:</h4>
<p><span class="user-mention" data-user-id="121055">@Pietro Albini</span> <a href="https://github.com/rust-lang/blog.rust-lang.org/pull/851">https://github.com/rust-lang/blog.rust-lang.org/pull/851</a></p>



<a name="242783429"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242783429" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242783429">(Jun 15 2021 at 19:05)</a>:</h4>
<p>looking</p>



<a name="242783775"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242783775" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242783775">(Jun 15 2021 at 19:08)</a>:</h4>
<p>merged!</p>



<a name="242903938"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242903938" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> cuviper <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242903938">(Jun 16 2021 at 16:13)</a>:</h4>
<p>Are we settled on inaction for <code>BITS</code>?</p>



<a name="242906824"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242906824" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242906824">(Jun 16 2021 at 16:35)</a>:</h4>
<p>just compat notes, I think, I've not had time to submit a PR yet unfortunately</p>



<a name="242906876"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242906876" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242906876">(Jun 16 2021 at 16:36)</a>:</h4>
<p>would be great if someone could own that!</p>



<a name="242907196"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242907196" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> cuviper <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242907196">(Jun 16 2021 at 16:38)</a>:</h4>
<p>I can do that. Should I call out <code>lexical-core</code> by name, or be more vague about it?</p>



<a name="242907332"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242907332" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Mara <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242907332">(Jun 16 2021 at 16:39)</a>:</h4>
<p>should it go in the blog post too?</p>



<a name="242907464"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242907464" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Mara <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242907464">(Jun 16 2021 at 16:40)</a>:</h4>
<p><span class="user-mention" data-user-id="138448">@cuviper</span> i think calling it out by name is useful, because then you can tell people to use <code>cargo update -p lexical-core</code> without updating all their other dependencies.</p>



<a name="242907582"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242907582" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242907582">(Jun 16 2021 at 16:41)</a>:</h4>
<p>hm, I've thought about including the compat notes section in the blog post in some fashion, but I worry it puts too much emphasis on it</p>



<a name="242907724"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242907724" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242907724">(Jun 16 2021 at 16:42)</a>:</h4>
<p>I think linking to it directly is probably not possible, right? or at least, that link will go stale, because the heading doesn't contain a date/release in it</p>



<a name="242907759"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242907759" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> cuviper <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242907759">(Jun 16 2021 at 16:42)</a>:</h4>
<p>I hope the plain release notes are enough for this -- should be google-able</p>



<a name="242952092"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242952092" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> cuviper <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242952092">(Jun 16 2021 at 22:36)</a>:</h4>
<p><a href="https://github.com/rust-lang/rust/pull/86380">https://github.com/rust-lang/rust/pull/86380</a></p>



<a name="242957603"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242957603" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242957603">(Jun 16 2021 at 23:47)</a>:</h4>
<p>looks like there's a last minute clippy ICE</p>



<a name="242957604"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242957604" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242957604">(Jun 16 2021 at 23:47)</a>:</h4>
<p><a href="https://internals.rust-lang.org/t/1-53-0-prerelease-testing/14884/2?u=mark_simulacrum">https://internals.rust-lang.org/t/1-53-0-prerelease-testing/14884/2?u=mark_simulacrum</a></p>



<a name="242965709"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242965709" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242965709">(Jun 17 2021 at 02:20)</a>:</h4>
<p>I ran out of time yesterday and today to do the beta promoting and master bootstrapping, but my day looks a little better tomorrow and friday so should be able to finish them then.</p>
<p><span class="user-mention" data-user-id="121055">@Pietro Albini</span> I suspect you'll be up earlier than I; I'm not sure we can do much about the Clippy ICE on such short notice, but maybe we could prepare a new set of artifacts with a backport... I'll try to kick off a stable-next PR so we have the artifacts for a decision tomorow morning right before going to bed (i.e., now)</p>



<a name="242965817"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242965817" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242965817">(Jun 17 2021 at 02:22)</a>:</h4>
<p>looks like the fix is in 1.54, at least, so we don't need beta backports; it landed in <a href="https://github.com/rust-lang/rust/pull/84980">https://github.com/rust-lang/rust/pull/84980</a></p>



<a name="242966005"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242966005" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242966005">(Jun 17 2021 at 02:27)</a>:</h4>
<p><a href="https://github.com/rust-lang/rust/pull/86390">https://github.com/rust-lang/rust/pull/86390</a></p>



<a name="242987817"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242987817" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242987817">(Jun 17 2021 at 08:37)</a>:</h4>
<p>ok with rustup-toolchain-install-master confirmed the new PR fixes the <a href="http://crates.io">crates.io</a> ICE</p>



<a name="242987895"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/242987895" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#242987895">(Jun 17 2021 at 08:38)</a>:</h4>
<p>+1 from me to release the new artifacts</p>



<a name="243014501"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/243014501" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#243014501">(Jun 17 2021 at 13:11)</a>:</h4>
<p><span class="user-mention" data-user-id="121055">@Pietro Albini</span> we have another bug in rustfmt it looks like - <a href="https://github.com/rust-lang/rustfmt/issues/4874">https://github.com/rust-lang/rustfmt/issues/4874</a></p>



<a name="243014534"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/243014534" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#243014534">(Jun 17 2021 at 13:11)</a>:</h4>
<p>My guess is it's not getting fixed today, so probably blocking on it doesn't make sense?</p>



<a name="243014607"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/243014607" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#243014607">(Jun 17 2021 at 13:12)</a>:</h4>
<p>But I would like a <span aria-label="thumbs up" class="emoji emoji-1f44d" role="img" title="thumbs up">:thumbs_up:</span> from someone else on that decision before I proceed with the release</p>



<a name="243014611"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/243014611" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#243014611">(Jun 17 2021 at 13:12)</a>:</h4>
<p>cc <span class="user-group-mention" data-user-group-id="2907">@T-release</span></p>



<a name="243014671"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/243014671" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#243014671">(Jun 17 2021 at 13:12)</a>:</h4>
<p>should we ask the rustfmt wg?</p>



<a name="243014693"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/243014693" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#243014693">(Jun 17 2021 at 13:12)</a>:</h4>
<p>also, this release is making me worried... or well, the past couple of releases</p>



<a name="243014703"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/243014703" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#243014703">(Jun 17 2021 at 13:13)</a>:</h4>
<p>a lot of things are slipping</p>



<a name="243014767"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/243014767" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#243014767">(Jun 17 2021 at 13:13)</a>:</h4>
<p>Yeah, I mean, there are very limited resources it seems to me. Not sure how much can be done about it.</p>



<a name="243014805"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/243014805" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#243014805">(Jun 17 2021 at 13:13)</a>:</h4>
<p>I'll see if I can ping the rustfmt folks</p>



<a name="243014959"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/243014959" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#243014959">(Jun 17 2021 at 13:15)</a>:</h4>
<p>DM'd <span class="user-mention" data-user-id="320317">@Caleb Cartwright</span> on discord</p>



<a name="243015014"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/243015014" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> cuviper <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#243015014">(Jun 17 2021 at 13:15)</a>:</h4>
<p>As long as it's not <em>damaging</em> the missing files, I agree we don't need to block on this</p>



<a name="243015094"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/243015094" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#243015094">(Jun 17 2021 at 13:16)</a>:</h4>
<p>it doesn't seem <em>horrible</em> to me, the only thing I could see it affecting is autogenerated code</p>



<a name="243015095"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/243015095" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#243015095">(Jun 17 2021 at 13:16)</a>:</h4>
<p>Sounds like he's looking into it so I'll wait a bit</p>



<a name="243016016"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/243016016" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#243016016">(Jun 17 2021 at 13:22)</a>:</h4>
<p>Sounds like it's a bit indeterminate and won't be known what the timeline on a fix is for at least several hours for now</p>



<a name="243016043"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/243016043" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#243016043">(Jun 17 2021 at 13:22)</a>:</h4>
<p>I think we should move ahead</p>



<a name="243016968"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/243016968" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> XAMPPRocky <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#243016968">(Jun 17 2021 at 13:28)</a>:</h4>
<p>Hmm, well for people who have format checking enabled in CI, what would the impact of this be? I don't think there would be any real effect since it's just not touching more files, but I want to make sure I'm not missing something.</p>



<a name="243017019"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/243017019" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#243017019">(Jun 17 2021 at 13:29)</a>:</h4>
<p>It's my understanding that the files are essentially ignored by rustfmt</p>



<a name="243017041"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/243017041" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#243017041">(Jun 17 2021 at 13:29)</a>:</h4>
<p>so they'd not be checked or formatted either way</p>



<a name="243017084"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/243017084" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#243017084">(Jun 17 2021 at 13:29)</a>:</h4>
<p>and in-editor formatting should still work, since that usually runs rustfmt on an individual file I think (not cargo fmt)</p>



<a name="243017274"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/243017274" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#243017274">(Jun 17 2021 at 13:30)</a>:</h4>
<p>ok, presuming no comments in next ~5 minutes I'll kick off the release</p>



<a name="243017559"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/243017559" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> XAMPPRocky <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#243017559">(Jun 17 2021 at 13:32)</a>:</h4>
<p><span class="user-mention silent" data-user-id="116122">simulacrum</span> <a href="#narrow/stream/241545-t-release/topic/1.2E53.20release/near/243017019">said</a>:</p>
<blockquote>
<p>It's my understanding that the files are essentially ignored by rustfmt</p>
</blockquote>
<p>Right I'm just thinking of a situation where I push code that is not formatted, and that would be accepted in 1.53, but then would be rejected by 1.54. So this might come up for projects that are always the latest stable immediately, rather than those that pin and upgrade. But just running <code>cargo +nightly fmt</code> seems like a reasonable workaround if that is the case.</p>



<a name="243017721"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/243017721" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#243017721">(Jun 17 2021 at 13:34)</a>:</h4>
<p>Well, minor changes to formatting happen regardless, but yes, that's a possible case I believe (presuming we backport the fix to 1.54, of course)</p>



<a name="243017788"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/243017788" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> XAMPPRocky <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#243017788">(Jun 17 2021 at 13:35)</a>:</h4>
<p>Also unrelated, I just realised that we're closer to 1.100.0 now than 1.0.0. That's odd to think about.</p>



<a name="243019156"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/243019156" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#243019156">(Jun 17 2021 at 13:44)</a>:</h4>
<p>ok, kicking off stable build</p>



<a name="243020960"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/243020960" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#243020960">(Jun 17 2021 at 13:56)</a>:</h4>
<p><span class="user-mention" data-user-id="116122">@simulacrum</span> can you DM steve on discord when you merge the blog post so he can tweet it?</p>



<a name="243020983"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/243020983" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#243020983">(Jun 17 2021 at 13:56)</a>:</h4>
<p>sure</p>



<a name="243020990"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/243020990" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#243020990">(Jun 17 2021 at 13:57)</a>:</h4>
<p>I'll ping now as a warning</p>



<a name="243028084"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/243028084" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#243028084">(Jun 17 2021 at 14:42)</a>:</h4>
<p>ok, merging blog</p>



<a name="243028288"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/243028288" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#243028288">(Jun 17 2021 at 14:44)</a>:</h4>
<p>hm, cargo release is going to be a problem, cc <span class="user-mention" data-user-id="121055">@Pietro Albini</span> <span class="user-mention" data-user-id="120518">@Eric Huss</span> </p>
<div class="codehilite"><pre><span></span><code>Caused by:
  the remote server responded with an error: this crate exists but you don&#39;t seem to be an owner. If you believe this is a mistake, perhaps you need to accept an invitation to be an owner before publishing.
</code></pre></div>



<a name="243028296"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/243028296" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#243028296">(Jun 17 2021 at 14:44)</a>:</h4>
<p>for <a href="https://crates.io/crates/cargo-util">https://crates.io/crates/cargo-util</a></p>



<a name="243028334"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/243028334" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#243028334">(Jun 17 2021 at 14:44)</a>:</h4>
<p><span class="user-mention" data-user-id="116122">@simulacrum</span> generate a rust-lang-owner <a href="http://crates.io">crates.io</a> token and use it for publishing?</p>



<a name="243028432"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/243028432" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#243028432">(Jun 17 2021 at 14:45)</a>:</h4>
<p>yeah, I guess. I think I'd prefer we create a rust-lang/publishers or something team that we can add you and me to, so we're not using the owner credentials regularly</p>



<a name="243028454"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/243028454" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#243028454">(Jun 17 2021 at 14:45)</a>:</h4>
<p>yeah definitely</p>



<a name="243028963"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/243028963" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Eric Huss <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#243028963">(Jun 17 2021 at 14:48)</a>:</h4>
<p><span aria-label="frown" class="emoji emoji-1f641" role="img" title="frown">:frown:</span>  Let me know if I can help in any way. There seems to be quite a few different github teams so it is a bit confusing to me (rust-lang-owner, rust-lang:libs, rust-lang-nursery:libs, and rust-lang:core).   I'm guessing maybe you usually have a token that works with rust-lang:core?</p>



<a name="243028999"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/243028999" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#243028999">(Jun 17 2021 at 14:48)</a>:</h4>
<p>well, I use my personal token and am on core</p>



<a name="243029061"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/243029061" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#243029061">(Jun 17 2021 at 14:49)</a>:</h4>
<p><span class="user-mention" data-user-id="121055">@Pietro Albini</span> do you think it makes sense to make this team in team repo? That's probably best, right?</p>



<a name="243029116"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/243029116" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#243029116">(Jun 17 2021 at 14:49)</a>:</h4>
<p>yeah I'd create a "release-doers" subteam of release to grant release-related perms</p>



<a name="243029122"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/243029122" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#243029122">(Jun 17 2021 at 14:49)</a>:</h4>
<p>sounds good</p>



<a name="243029132"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/243029132" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#243029132">(Jun 17 2021 at 14:49)</a>:</h4>
<p>with a better name (release-drivers? release-managers?)</p>



<a name="243029159"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/243029159" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#243029159">(Jun 17 2021 at 14:49)</a>:</h4>
<p>release-publishers? :)</p>



<a name="243029214"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/243029214" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#243029214">(Jun 17 2021 at 14:50)</a>:</h4>
<p>even better!</p>



<a name="243039715"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/243039715" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#243039715">(Jun 17 2021 at 15:52)</a>:</h4>
<p>ok, only cargo-util actually needed it this time, we can expand it to the other crates over time (it's a bit of a pain since I need to invite myself, then invite the team, then remove myself)</p>



<a name="243039757"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/243039757" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#243039757">(Jun 17 2021 at 15:52)</a>:</h4>
<p>I don't have the patience to do that for the not actually relevant crates right this moment</p>



<a name="243043688"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/243043688" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Caleb Cartwright <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#243043688">(Jun 17 2021 at 16:18)</a>:</h4>
<p><span class="user-mention silent" data-user-id="219696">XAMPPRocky</span> <a href="#narrow/stream/241545-t-release/topic/1.2E53.20release/near/243017559">said</a>:</p>
<blockquote>
<p><span class="user-mention silent" data-user-id="116122">simulacrum</span> <a href="#narrow/stream/241545-t-release/topic/1.2E53.20release/near/243017019">said</a>:</p>
<blockquote>
<p>It's my understanding that the files are essentially ignored by rustfmt</p>
</blockquote>
<p>Right I'm just thinking of a situation where I push code that is not formatted, and that would be accepted in 1.53, but then would be rejected by 1.54. So this might come up for projects that are always the latest stable immediately, rather than those that pin and upgrade. But just running <code>cargo +nightly fmt</code> seems like a reasonable workaround if that is the case.</p>
</blockquote>
<p>bug fixes are covered under the formatting stability guarantee. obviously it's undesirable, but bugs are inevitable and it's allowed (and somewhat common) for a bug fix to result in rustfmt being able to format something it wasn't formatting prior to the fix.</p>
<p>there's also some fairly long standing issues around mod resolution, and it's not uncommon in cases like this where new mod resolution bugs are introduced within rustfmt after there's impactful changes in rustc_parse and rustc_ast. one of the benefits (hopefully) of moving rustfmt to a subtree is that those types of changes will be made in tandem going forward vs. us having to retroactively try to figure out what changed in rustc and adapt rustfmt accordingly</p>



<a name="243043958"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/243043958" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Caleb Cartwright <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#243043958">(Jun 17 2021 at 16:20)</a>:</h4>
<p><span class="user-mention silent" data-user-id="121055">Pietro Albini</span> <a href="#narrow/stream/241545-t-release/topic/1.2E53.20release/near/243014693">said</a>:</p>
<blockquote>
<p>also, this release is making me worried... or well, the past couple of releases</p>
</blockquote>
<p>is this specifically related to rustfmt or just in general? if the former i'd find it helpful if you could share some details with me at some point. i don't personally feel like our rate of bugs has really changed all that much, so more info would be most helpful</p>



<a name="243044319"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/243044319" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> cuviper <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#243044319">(Jun 17 2021 at 16:23)</a>:</h4>
<p>I think that was a general concern -- we've had a few things coming in last-minute</p>



<a name="243044649"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/243044649" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#243044649">(Jun 17 2021 at 16:25)</a>:</h4>
<p>yeah <span class="user-mention" data-user-id="320317">@Caleb Cartwright</span> it was not meant for rustfmt!</p>



<a name="243044722"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/243044722" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#243044722">(Jun 17 2021 at 16:26)</a>:</h4>
<p>we just had a bunch of last-minute stuff for 1.53 and especially 1.52</p>



<a name="243044744"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/243044744" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Caleb Cartwright <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#243044744">(Jun 17 2021 at 16:26)</a>:</h4>
<p>gotcha, that makes sense thanks!</p>



<a name="243044988"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/243044988" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> cuviper <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#243044988">(Jun 17 2021 at 16:28)</a>:</h4>
<p>maybe our "pre-release testing" blog posts could also remind people to try the next beta?</p>



<a name="243045016"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/243045016" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> cuviper <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#243045016">(Jun 17 2021 at 16:28)</a>:</h4>
<p>"we're about to release this, but please also test for the future..."</p>



<a name="243045153"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/243045153" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#243045153">(Jun 17 2021 at 16:29)</a>:</h4>
<p>I think we'd want to shuffle schedules around to do that or something like it - we don't usually have a beta by the prerelease post</p>



<a name="243045322"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/243045322" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> cuviper <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#243045322">(Jun 17 2021 at 16:30)</a>:</h4>
<p>if that shuffling is feasible, I think it would be helpful</p>



<a name="243045353"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/243045353" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#243045353">(Jun 17 2021 at 16:30)</a>:</h4>
<p>a thing we could do is moving everything a week before the release</p>



<a name="243045384"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/243045384" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#243045384">(Jun 17 2021 at 16:31)</a>:</h4>
<p>so that we have a full week of pre-release testing (and the time to address it)</p>



<a name="243045385"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/243045385" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> cuviper <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#243045385">(Jun 17 2021 at 16:31)</a>:</h4>
<p>we could also ask for beta feedback separately, but I don't want to cause fatigue</p>



<a name="243045635"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/243045635" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#243045635">(Jun 17 2021 at 16:32)</a>:</h4>
<p>should the relnotes be modified to explicitly note that RUSTC_FORCE_INCREMENTAL is still necessary to get incr-comp ?</p>



<a name="243045755"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/243045755" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#243045755">(Jun 17 2021 at 16:33)</a>:</h4>
<p>on the one hand it doesn’t feel great to draw attention to the matter. on the other hand, not mentioning it at all is probably confusing to people who have been following the blog entries for 1.52.0 and 1.52.1</p>



<a name="243046130"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/243046130" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> XAMPPRocky <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#243046130">(Jun 17 2021 at 16:36)</a>:</h4>
<p>I have no feeling either way, seems fine to include to me. I can mention that the incr-comp was one of things someone asked about at work when talking about the new release, so anecdotally there’s definitely some people wondering.</p>



<a name="243046138"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/243046138" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> inquisitivecrystal <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#243046138">(Jun 17 2021 at 16:36)</a>:</h4>
<p>Random inexperienced drive-by commenter here: it feels to me like it should be mentioned. The current behavior is a confusing exception to how a core part of the compilation process works. If incremental compilation is broken, which it currently is, that should be as visible as possible.</p>



<a name="243046555"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/243046555" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> XAMPPRocky <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#243046555">(Jun 17 2021 at 16:39)</a>:</h4>
<p><span class="user-mention silent" data-user-id="121055">Pietro Albini</span> <a href="#narrow/stream/241545-t-release/topic/1.2E53.20release/near/243045353">said</a>:</p>
<blockquote>
<p>a thing we could do is moving everything a week before the release</p>
</blockquote>
<p>I think this is the right approach for the future. A week is pretty substantial compared to a few days because it will give time for both professionals during the weekday and hobbyists during the weekend to test the new release. It also gives us more runway to address any issues that come up in the pre-release.</p>



<a name="243046948"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/243046948" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#243046948">(Jun 17 2021 at 16:42)</a>:</h4>
<p>I’ll make a PR against the blog post</p>



<a name="243049211"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/243049211" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#243049211">(Jun 17 2021 at 16:56)</a>:</h4>
<p><a href="https://github.com/rust-lang/blog.rust-lang.org/pull/854">https://github.com/rust-lang/blog.rust-lang.org/pull/854</a></p>



<a name="243066132"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/243066132" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#243066132">(Jun 17 2021 at 18:53)</a>:</h4>
<p>ok, going to go ahead and actually branch beta and such now</p>



<a name="243066887"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.53%20release/near/243066887" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E53.20release.html#243066887">(Jun 17 2021 at 18:59)</a>:</h4>
<p>branched, working on the stage0.txt changes...</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>